Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1945643005: Don't wrap type literals that are referenced by prefixes. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't wrap type literals that are referenced by prefixes. Also, fix the language test for this to actually do something useful. I accidentally removed the definition of testType() in the last patch, so the test did nothing. :( Fixes #547. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/94eef8d7acf6c8def3de5a5e4c503e31c5a84fe0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M lib/src/compiler/code_generator.dart View 2 chunks +27 lines, -4 lines 0 comments Download
M test/codegen/language/type_literal_test.dart View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-04 02:25:24 UTC) #3
vsm
lgtm
4 years, 7 months ago (2016-05-04 03:08:43 UTC) #4
Bob Nystrom
4 years, 7 months ago (2016-05-04 17:13:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94eef8d7acf6c8def3de5a5e4c503e31c5a84fe0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698