Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Issue 1945643003: Revert of Android integration tests for PaymentRequest (Closed)

Created:
4 years, 7 months ago by sclittle
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@address-in-result
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android integration tests for PaymentRequest (patchset #3 id:80001 of https://codereview.chromium.org/1941623002/ ) Reason for revert: These integration tests are currently failing on the bots: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34100, https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34101 Original issue's description: > Android integration tests for PaymentRequest UI > > This patch adds several integration tests for PaymentRequest UI on > Android: > > - Clicking X should cancel the PaymentRequest. > > - Clicking EDIT and then X should cancel the PaymentRequest. > > - Clicking EDIT and then CANCEL should cancel the PaymentRequest. > > - Clicking PAY should provide the merchant with an autofill credit > card and (if requested) an autofill profile as a shipping address. > > BUG=608223 > > Committed: https://crrev.com/68aec80e25847bd6fe7763edfff90e44f8557bc2 > Cr-Commit-Position: refs/heads/master@{#391304} TBR=dfalcantara@chromium.org,rouslan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608223 Committed: https://crrev.com/2e6c0588e2c714c655d0dd36a744537ffcf8b229 Cr-Commit-Position: refs/heads/master@{#391381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -548 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 6 chunks +6 lines, -50 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 7 chunks +8 lines, -54 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 2 chunks +2 lines, -3 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_free_shipping_test.html View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_no_shipping_test.html View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sclittle
Created Revert of Android integration tests for PaymentRequest
4 years, 7 months ago (2016-05-03 22:42:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945643003/1
4 years, 7 months ago (2016-05-03 22:42:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 22:43:07 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:44:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e6c0588e2c714c655d0dd36a744537ffcf8b229
Cr-Commit-Position: refs/heads/master@{#391381}

Powered by Google App Engine
This is Rietveld 408576698