Issue 194563003: Fix linking errors on android builds due to cdd0f92b1ac

Issue 194563003: Fix linking errors on android builds due to cdd0f92b1ac (Closed)

Created:
6 years, 9 months ago by hal.canary

Modified:
6 years, 9 months ago

Reviewers:
iancottrell, ian_cottrell, tomhudson

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix linking errors on android builds due to cdd0f92b1ac NOTREECHECKS=true NOTRY=true TBR=tomhudson@google.com Committed: http://code.google.com/p/skia/source/detail?r=13745

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/bbh_shootout.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hal.canary

Does this change look okay to you? http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-GalaxyNexus/builds/2834

6 years, 9 months ago (2014-03-11 19:06:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/194563003/1

6 years, 9 months ago (2014-03-11 19:12:21 UTC) #3

ian_cottrell

On 2014/03/11 19:06:45, Hal Canary wrote: > Does this change look okay to you? > ...

6 years, 9 months ago (2014-03-11 19:32:48 UTC) #5

hal.canary

6 years, 9 months ago (2014-03-11 19:34:54 UTC) #6

Message was sent while issue was closed.

On 2014/03/11 19:32:48, ian_cottrell wrote:
> On 2014/03/11 19:06:45, Hal Canary wrote:
> > Does this change look okay to you?
> > 
> >
>
http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-GalaxyNex...
> 
> lgtm and thanks.
> Weird error though, that entire compilation unit gets dropped without
colliding
> on the other platforms...

I asked about it — it's only on android that we link everything together.

Expand Messages | Collapse Messages