Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5100)

Unified Diff: chrome/gpu/arc_gpu_video_decode_accelerator.h

Issue 1945543002: Use explicit flush for ArcVideoAccelerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and update version Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gpu/arc_gpu_video_decode_accelerator.h
diff --git a/chrome/gpu/arc_gpu_video_decode_accelerator.h b/chrome/gpu/arc_gpu_video_decode_accelerator.h
index e29f9aaa69344014aa6a94692a838ac119e410b8..d4cc4200487490bdc14852d108889e73ae891b54 100644
--- a/chrome/gpu/arc_gpu_video_decode_accelerator.h
+++ b/chrome/gpu/arc_gpu_video_decode_accelerator.h
@@ -47,6 +47,7 @@ class ArcGpuVideoDecodeAccelerator
uint32_t index,
const BufferMetadata& metadata) override;
void Reset() override;
+ void Flush() override;
// Implementation of the VideoDecodeAccelerator::Client interface.
void ProvidePictureBuffers(uint32_t requested_num_of_buffers,
@@ -86,10 +87,6 @@ class ArcGpuVideoDecodeAccelerator
~InputBufferInfo();
};
- // Helper function to Send the end-of-stream output buffer if
- // |pending_eos_output_buffer_| is true, or reuse the picture in ArcVDA.
- void SendEosIfNeededOrReusePicture(uint32_t index);
-
// Helper function to validate |port| and |index|.
bool ValidatePortAndIndex(PortType port, uint32_t index);
@@ -104,10 +101,6 @@ class ArcGpuVideoDecodeAccelerator
// Returns |nullptr| if it cannot be found.
InputRecord* FindInputRecord(int32_t bitstream_buffer_id);
- // When true, an EOS output buffer need to be sent to |arc_client_| once an
- // output buffer is available.
- bool pending_eos_output_buffer_;
-
std::unique_ptr<media::VideoDecodeAccelerator> vda_;
// It's safe to use the pointer here, the life cycle of the |arc_client_|
@@ -119,13 +112,6 @@ class ArcGpuVideoDecodeAccelerator
gfx::Size coded_size_;
- // The |picture_buffer_id|s for Pictures that were returned to us from VDA
- // via PictureReady() while flushing. We keep them until NotifyFlushDone();
- // once it's called, we send one of the pending buffers from this queue (if
- // not empty), marked with an EOS flag, to |arc_client_|, and return the rest
- // to VDA for reuse.
- std::queue<int32_t> buffers_pending_eos_;
-
// A list of most recent |kMaxNumberOfInputRecord| InputRecords.
// |kMaxNumberOfInputRecord| is defined in the cc file.
std::list<InputRecord> input_records_;
« no previous file with comments | « no previous file | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698