Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1945533002: Add way to mark other Surface a predecessor for a Surface. (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add way to mark other Surface a predecessor for a Surface. Previously-unseen Surfaces are always treated as being completely damaged. However, sometimes it makes sense to essentially clone a Surface with a new SurfaceId for synchronization. In those circumstances, it's possible to treat the damage of the first frame of the new Surface as being against the last frame of the old Surface, so add a way to signal that. BUG=549781 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8ab5d072f4dbb238ffc5fdad7d5d87fc22850e35 Cr-Commit-Position: refs/heads/master@{#392523}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -7 lines) Patch
M cc/surfaces/surface.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 3 1 chunk +15 lines, -7 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbauman
4 years, 7 months ago (2016-05-07 01:36:52 UTC) #4
piman
lgtm
4 years, 7 months ago (2016-05-09 16:31:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945533002/60001
4 years, 7 months ago (2016-05-10 01:03:41 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 02:29:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:31:14 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ab5d072f4dbb238ffc5fdad7d5d87fc22850e35
Cr-Commit-Position: refs/heads/master@{#392523}

Powered by Google App Engine
This is Rietveld 408576698