Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/BUILD.gn

Issue 1945473002: Break dependencies of browser -> blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android filter Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/client/BUILD.gn ('K') | « blimp/client/BUILD.gn ('k') | components/password_manager/content/public/cpp/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 17d6ca845041f1f375adc7044aba0b2acc14c9e3..df46adc4200317f8c0a966288872cd225a762745 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -728,9 +728,7 @@ group("browser_dependencies") {
# build this is OK because all of content is linked into one library.
# Note that the blink_headers target is OK, so we can't do a wildcard for
# all blink targets.
- # TODO(brettw) bug 582206: Blink should not be linked into the browser
- # process, and then we can enable this.
- #"//third_party/WebKit/public:blink",
+ "//third_party/WebKit/public:blink",
# TODO(brettw) bug 581766: V8 should not be linked into the browser
# process, and then we can enable this.
#"//v8/*",
« blimp/client/BUILD.gn ('K') | « blimp/client/BUILD.gn ('k') | components/password_manager/content/public/cpp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698