blimp/client/BUILD.gn - Issue 1945473002: Break dependencies of browser -> blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 1945473002: Break dependencies of browser -> blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android filter Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 1bc9217a2f9963e7910ac67aef8fc19d18bc4efd..a916d9e42d20ebfa6d17fd9b6bce17d94e993d6b 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -202,6 +202,7 @@ if (is_linux && !is_chromeos && use_x11) {

"//base",

"//blimp/net",

"//net",

+ "//third_party/WebKit/public:blink",

Khushal 2016/05/04 02:02:19 blimp/client should not need to depend on blink. I

scottmg 2016/05/04 17:02:57 safe_json may be another problem, but the link err

Khushal 2016/05/04 18:09:31 Sorry I missed this earlier. Thanks! +nyquist@ to

"//ui/events/platform/x11",

"//ui/platform_window",

"//ui/platform_window/x11",

« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »