Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1945443002: Convert callers of base::DeepCopy() to base::CreateDeepCopy() in //remoting (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert callers of base::DeepCopy() to base::CreateDeepCopy() in //remoting BUG=581865 R=kelvinp@chromium.org Committed: https://crrev.com/efaf1b116773bbbc1b5e77358171f8c8d6b6b771 Cr-Commit-Position: refs/heads/master@{#391137}

Patch Set 1 #

Patch Set 2 : 3 more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_watcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/signaling/chromoting_event.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
4 years, 7 months ago (2016-05-02 22:18:33 UTC) #1
kelvinp
lgtm
4 years, 7 months ago (2016-05-02 23:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945443002/20001
4 years, 7 months ago (2016-05-03 00:26:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 01:13:03 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:14:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efaf1b116773bbbc1b5e77358171f8c8d6b6b771
Cr-Commit-Position: refs/heads/master@{#391137}

Powered by Google App Engine
This is Rietveld 408576698