[Extensions] Update more bindings and allow for multiple feature access

[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164
Committed: https://crrev.com/908ac08879c13a2c74573e88c0ca9d3f1f69eacd
Cr-Commit-Position: refs/heads/master@{#392182}

[Devlin, 2016-05-05 22:18:09]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-05-05 22:19:24]

Description was changed from

==========
inprog

BUG=
==========

to

==========
[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164
==========

[Devlin, 2016-05-05 22:20:21]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-05-05 22:20:22]

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
File extensions/renderer/object_backed_native_handler.cc (right):

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
extensions/renderer/object_backed_native_handler.cc:146:
base::Bind(&ValidateAndCall, handler_function, features);
This callback trickery struck me as easier than storing a vector of strings in
the v8 object.

[asargent_no_longer_on_chrome, 2016-05-06 17:09:04]

lgtm with one question

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/app...
File extensions/renderer/app_window_custom_bindings.cc (right):

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/app...
extensions/renderer/app_window_custom_bindings.cc:26:
std::vector<std::string>({"app.window", "input.ime"}),
why is "input.ime" here in app_window_custom_bindings? (whatever the answer is,
it probably deserves adding a comment here)

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
File extensions/renderer/object_backed_native_handler.cc (right):

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
extensions/renderer/object_backed_native_handler.cc:25: using
HandlerFunctionCheck =
nit: this could use a comment

[Devlin, 2016-05-06 22:13:47]

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/app...
File extensions/renderer/app_window_custom_bindings.cc (right):

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/app...
extensions/renderer/app_window_custom_bindings.cc:26:
std::vector<std::string>({"app.window", "input.ime"}),
On 2016/05/06 17:09:04, Antony Sargent wrote:
> why is "input.ime" here in app_window_custom_bindings? (whatever the answer
is,
> it probably deserves adding a comment here)

Done.

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
File extensions/renderer/object_backed_native_handler.cc (right):

https://codereview.chromium.org/1945433002/diff/20001/extensions/renderer/obj...
extensions/renderer/object_backed_native_handler.cc:25: using
HandlerFunctionCheck =
On 2016/05/06 17:09:04, Antony Sargent wrote:
> nit: this could use a comment

Done.

[Devlin, 2016-05-06 22:13:52]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-05-06 22:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1945433002/#ps40001
(title: "Antony's")

[commit-bot: I haz the power, 2016-05-06 22:14:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945433002/40001

[commit-bot: I haz the power, 2016-05-06 22:22:03]

Description was changed from

==========
[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164
==========

to

==========
[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164
==========

[commit-bot: I haz the power, 2016-05-06 22:22:04]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-06 22:23:31]

Description was changed from

==========
[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164
==========

to

==========
[Extensions] Update more bindings and allow for multiple feature access

Update more of the native handler bindings and allow for handler
functions that are called by multiple features.

BUG=591164

Committed: https://crrev.com/908ac08879c13a2c74573e88c0ca9d3f1f69eacd
Cr-Commit-Position: refs/heads/master@{#392182}
==========

[commit-bot: I haz the power, 2016-05-06 22:23:31]

Patchset 2 (id:??) landed as
https://crrev.com/908ac08879c13a2c74573e88c0ca9d3f1f69eacd
Cr-Commit-Position: refs/heads/master@{#392182}

[Devlin, 2016-05-09 13:32:25]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1964483002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: This may have caused a blink bindings perf
regression: crbug.com/610248.  Speculatively reverting and will reland if it's
not the issue..