Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 194543002: Removing base::Time from SetAnimationEvents and PostAnimationEventsToMainThreadOnImplThread. (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
danakj, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing base::Time from SetAnimationEvents and PostAnimationEventsToMainThreadOnImplThread. As of "Remove wall time from NotifyAnimationStarted and NotifyAnimationFinished" (https://src.chromium.org/viewvc/chrome?view=rev&revision=255888) the wall time is no longer used in either of these functions. BUG=299945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256237

Patch Set 1 #

Patch Set 2 : Removing unused last_animation_time_ as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -33 lines) Patch
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.cc View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mithro-old
More base::Time removal in the animation events area. Should be the final CL needed to ...
6 years, 9 months ago (2014-03-11 08:25:49 UTC) #1
ajuma
lgtm
6 years, 9 months ago (2014-03-11 13:09:15 UTC) #2
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-11 13:57:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/194543002/20001
6 years, 9 months ago (2014-03-11 13:57:18 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 15:37:52 UTC) #5
Message was sent while issue was closed.
Change committed as 256237

Powered by Google App Engine
This is Rietveld 408576698