Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 1945413003: Disable Ganesh layer hoister in a more revertable form (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable Ganesh layer hoister in a more revertable form I have a worry that disabling the layer hoister might cause a perf regression on tiled architectures. This CL will be easier to revert than https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1945413003 Committed: https://skia.googlesource.com/skia/+/325474dd42db6d5a16cc4cf18f06dad4e0d60e9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/gpu/GrLayerHoister.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 7 months ago (2016-05-04 18:00:02 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945413003/1
4 years, 7 months ago (2016-05-04 18:00:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 18:11:02 UTC) #10
bsalomon
On 2016/05/04 18:00:10, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 7 months ago (2016-05-04 18:14:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945413003/1
4 years, 7 months ago (2016-05-04 18:25:52 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:26:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/325474dd42db6d5a16cc4cf18f06dad4e0d60e9f

Powered by Google App Engine
This is Rietveld 408576698