Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1945353004: Revert of ash: reset color management when new screens are hotplugged (Closed)

Created:
4 years, 7 months ago by llandwerlin-old
Modified:
4 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ash: reset color management when new screens are hotplugged (patchset #3 id:30009 of https://codereview.chromium.org/1914343003/ ) Reason for revert: This is causing issues on ARM/exynos5420-peach-pit Chromebook. Let's revert this for now as I don't have a device to investigate. BUG=609256 Original issue's description: > ash: reset color management when new screens are plugged > > With the DRM drivers on ChromeOS, the color management tables and matrices > are stored at the pipe level (part of the display hardware that is > configurable regardless of the actual connector it is attached to). This > allows display configuration to remain active while different processes are > using the driver (for example switching VT). > > As a result, when an external screen is connected to a Chromebook, a given > color configuration might be applied to it and remain stored in the driver > after the screen is disconnected. If another external screen is now > connected the previously applied color management will remain if there is > not a profile for that display. > > This change takes care of resetting the color management matrices/tables on > newly connected screen before we apply a new configuration. > > BUG=495196 > TEST=Manual testing with hotplugging of a display and identify correct > behavior. > > Committed: https://crrev.com/5932a0131851f35b74be5d2fc86a3834defd4d8c > Cr-Commit-Position: refs/heads/master@{#391491} TBR=robert.bradford@intel.com,oshima@chromium.org,spang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495196 Committed: https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7 Cr-Commit-Position: refs/heads/master@{#391781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -85 lines) Patch
M ash/display/display_color_manager_chromeos.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/display/display_color_manager_chromeos_unittest.cc View 7 chunks +14 lines, -22 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 5 chunks +23 lines, -51 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_display.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
llandwerlin-old
Created Revert of ash: reset color management when new screens are hotplugged
4 years, 7 months ago (2016-05-05 09:23:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945353004/1
4 years, 7 months ago (2016-05-05 09:23:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 09:23:52 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 09:25:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7
Cr-Commit-Position: refs/heads/master@{#391781}

Powered by Google App Engine
This is Rietveld 408576698