Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1945343003: Revert of Modernize SkMutex and SkSemaphore. (Closed)

Created:
4 years, 7 months ago by sclittle
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Modernize SkMutex and SkSemaphore. (patchset #2 id:20001 of https://codereview.chromium.org/1947153002/ ) Reason for revert: This CL seems to have broken the Linux x64 and Mac bots, e.g. https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052 https://build.chromium.org/p/chromium/builders/Mac/builds/15151 The error appears to have something to do with new static initializers being added. Original issue's description: > Modernize SkMutex and SkSemaphore. > > - use <atomic> > - fuse SkMutex and SkBaseMutex > - fuse SkSemaphore and SkBaseSemaphore > > Still TODO: > - replace SK_DECLARE_STATIC_MUTEX(name) with static SkMutex name > > I just didn't want to bother fixing all that up until I know this CL sticks. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947153002 > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/427c2819d9237d7d7729c59238036cfc73c072ea TBR=herb@google.com,mtklein@chromium.org,reed@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609340 Committed: https://skia.googlesource.com/skia/+/d9f5d20f81b15190fa858eda1f536deae21e8e78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -75 lines) Patch
M include/core/SkPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/private/SkMutex.h View 3 chunks +37 lines, -13 lines 0 comments Download
M include/private/SkSemaphore.h View 2 chunks +53 lines, -43 lines 0 comments Download
M src/core/SkSemaphore.cpp View 4 chunks +38 lines, -11 lines 0 comments Download
M src/lazy/SkDiscardableMemoryPool.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sclittle
Created Revert of Modernize SkMutex and SkSemaphore.
4 years, 7 months ago (2016-05-05 00:40:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945343003/1
4 years, 7 months ago (2016-05-05 00:40:25 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-05 00:40:26 UTC) #3
sclittle
lgtm
4 years, 7 months ago (2016-05-05 00:42:33 UTC) #5
sclittle1
lgtm so that this can land quickly to fix the broken builders
4 years, 7 months ago (2016-05-05 00:45:37 UTC) #7
sclittle
4 years, 7 months ago (2016-05-05 01:19:25 UTC) #13
bsalomon
On 2016/05/05 01:19:25, sclittle wrote: lgtm
4 years, 7 months ago (2016-05-05 01:22:54 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 01:23:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9f5d20f81b15190fa858eda1f536deae21e8e78

Powered by Google App Engine
This is Rietveld 408576698