Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945343002: Add default manifest for gn nacl64.exe (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add default manifest for gn nacl64.exe BUG=604060 Committed: https://crrev.com/1a86e1e5cef109674814b73cfd606acf6152f2cc Cr-Commit-Position: refs/heads/master@{#391763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/nacl/broker/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
This adds a default manifest for nacl64.exe. This is the last in a series of ...
4 years, 7 months ago (2016-05-04 14:34:28 UTC) #2
bradnelson
lgtm lgtm rubberstamp
4 years, 7 months ago (2016-05-05 04:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945343002/1
4 years, 7 months ago (2016-05-05 04:23:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 05:17:52 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 05:18:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1a86e1e5cef109674814b73cfd606acf6152f2cc
Cr-Commit-Position: refs/heads/master@{#391763}

Powered by Google App Engine
This is Rietveld 408576698