Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945303003: [turbofan] Use kHeapObjectTag in place of hard-coded value. (Closed)

Created:
4 years, 7 months ago by MTBrandyberry
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use kHeapObjectTag in place of hard-coded value. R=bmeurer@chromium.org, jarin@chromium.org BUG= Committed: https://crrev.com/f6df485dc1592d2f96d08734b21d359283777846 Cr-Commit-Position: refs/heads/master@{#36062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 7 months ago (2016-05-04 21:07:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945303003/1
4 years, 7 months ago (2016-05-04 21:07:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 21:35:28 UTC) #5
Benedikt Meurer
LGTM, thanks.
4 years, 7 months ago (2016-05-06 03:52:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945303003/1
4 years, 7 months ago (2016-05-06 03:52:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 07:33:14 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:33:46 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f6df485dc1592d2f96d08734b21d359283777846
Cr-Commit-Position: refs/heads/master@{#36062}

Powered by Google App Engine
This is Rietveld 408576698