Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1945293003:
DevTools: fix styles in full text search input (Closed)
|
Created:
4 years, 7 months ago by luoe Modified:
4 years, 7 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: fix styles in full text search input
BUG=608615
Committed: https://crrev.com/7584daee96f12ce4339821e393ce15fd45cc422e
Cr-Commit-Position: refs/heads/master@{#391695}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (7 generated)
Description was changed from ========== DevTools: fix styles in full text search input BUG=608615 ========== to ========== DevTools: fix styles in full text search input BUG=608615 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
This adds a needed pixel of margin which, when missing, leads to a strange UI bug.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945293003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1945293003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css (right): https://codereview.chromium.org/1945293003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css:17: margin: 1px 0px 1px 1px; margin: 1px; wdyt?
The CQ bit was checked by luoe@chromium.org
https://codereview.chromium.org/1945293003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css (right): https://codereview.chromium.org/1945293003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css:17: margin: 1px 0px 1px 1px; On 2016/05/04 23:35:05, lushnikov wrote: > margin: 1px; > > wdyt? It's actually flush on both sides when it's 1 0 1 1.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945293003/1
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix styles in full text search input BUG=608615 ========== to ========== DevTools: fix styles in full text search input BUG=608615 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix styles in full text search input BUG=608615 ========== to ========== DevTools: fix styles in full text search input BUG=608615 Committed: https://crrev.com/7584daee96f12ce4339821e393ce15fd45cc422e Cr-Commit-Position: refs/heads/master@{#391695} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7584daee96f12ce4339821e393ce15fd45cc422e Cr-Commit-Position: refs/heads/master@{#391695} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
