Issue 1945283002: Fix build after bad merge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1945283002: Fix build after bad merge (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 7 months ago

Reviewers:
Michael Hablich

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix build after bad merge TBR=hablich@chromium.org BUG=v8:4909 LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/59c7657d642bf500c49da3c4bd0e6d7bf647ec7d

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	include/v8-version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/objects.cc	View		2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jochen (gone - plz use gerrit)

Committed patchset #1 (id:1) manually as 59c7657d642bf500c49da3c4bd0e6d7bf647ec7d (presubmit successful).

4 years, 7 months ago (2016-05-04 13:22:10 UTC) #3

Michael Hablich

4 years, 7 months ago (2016-05-04 14:16:41 UTC) #4

Message was sent while issue was closed.

On 2016/05/04 13:22:10, jochen wrote:
> Committed patchset #1 (id:1) manually as
> 59c7657d642bf500c49da3c4bd0e6d7bf647ec7d (presubmit successful).

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages