Chromium Code Reviews Chromium Code Reviews
Issue
1945273002:
Revert of Use actual audio channel count in Spitzer audio decoder (Closed)
DescriptionRevert of Use actual audio channel count in Spitzer audio decoder (patchset #5 id:80001 of https://codereview.chromium.org/1932093002/ )
Reason for revert:
This is breaking media_unittests. For some reasons, it seem to only apply on internal bots.
See: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester
Log extract:
I 46.291s Main FINISHED TRY #3/3
I 46.291s Main 1 failed tests remain.
C 46.297s Main ********************************************************************************
C 46.297s Main Detailed Logs
C 46.297s Main ********************************************************************************
C 46.299s Main [CRASH] MediaCodecAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0:
C 46.299s Main [ RUN ] MediaCodecAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0
C 46.299s Main [ERROR:aligned_memory.cc(38)] If you crashed here, your aligned allocation is incorrect: size=4294966720, alignment=32
C 46.299s Main [FATAL:aligned_memory.cc(40)] Check failed: false.
C 46.299s Main #00 0xa31c9979 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00c17979
C 46.299s Main #01 0xa31ca9e7 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00c189e7
C 46.299s Main #02 0xa2bc4779 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00612779
C 46.299s Main #03 0xa2bc49b5 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x006129b5
C 46.299s Main #04 0xa2830a7d /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x0027ea7d
C 46.299s Main #05 0xa2830ee5 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x0027eee5
C 46.299s Main #06 0xa2831031 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x0027f031
C 46.299s Main #07 0xa2831385 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x0027f385
C 46.299s Main #08 0xa279984b /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x001e784b
C 46.299s Main #09 0xa279a1b3 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x001e81b3
C 46.299s Main #10 0xa279d063 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x001eb063
C 46.299s Main #11 0xa31aa80f /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00bf880f
C 46.299s Main #12 0xa31aa941 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00bf8941
C 46.299s Main #13 0xa31aa9c9 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00bf89c9
C 46.300s Main #14 0xa31ad2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00bfb2d5
C 46.300s Main #15 0xa31a6e17 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00bf4e17
C 46.300s Main #16 0xa28533b9 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x002a13b9
C 46.300s Main #17 0xa285e43b /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x002ac43b
C 46.300s Main #18 0xa26bc287 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x0010a287
C 46.300s Main #19 0xa319a8d5 /data/app/org.chromium.native_test-1/lib/arm/lib_media_unittests__library.so+0x00be88d5
C 46.300s Main #20 0xaf35ea9f /data/dalvik-cache/arm/data@app@org.chromium.native_test-1@base.apk@classes.dex+0x00185a9f
C 46.300s Main
C 46.300s Main [ERROR:test_suite.cc(254)] Currently running: MediaCodecAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0
C 46.300s Main ********************************************************************************
C 46.300s Main Summary
C 46.300s Main ********************************************************************************
C 46.304s Main [==========] 2837 tests ran.
C 46.304s Main [ PASSED ] 2836 tests.
C 46.304s Main [ FAILED ] 1 test, listed below:
C 46.304s Main [ FAILED ] MediaCodecAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0 (CRASHED)
Original issue's description:
> Use actual audio channel count in Spitzer audio decoder
>
> The actual channel count used by MediaCodec for audio may be
> less than requested in case of multichannel AAC.
> MediaCodecAudioDecoder obtains the actual channel count
> in response to OUTPUT_FORMAT_CHANGED and uses it for the
> calculation of the sample length.
>
> In this CL we keep creating output buffers according to the
> requested configuration. If the actual number of channels is
> less than the requsted this CL fills the missing channels
> with zero data.
>
> BUG=607024
>
> Committed: https://crrev.com/f6d2c9a3aa0a72ff766a132ef7f245ea26f66dfc
> Cr-Commit-Position: refs/heads/master@{#391416}
TBR=dalecurtis@chromium.org,chcunningham@chromium.org,qinmin@chromium.org,timav@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607024
Committed: https://crrev.com/dac63f2dca3b672fd8062f5b51df5e964ddf49e3
Cr-Commit-Position: refs/heads/master@{#391484}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
