Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1945263002: [stubs] Fix Allocate macro in the CodeStubAssembler. (Closed)

Created:
4 years, 7 months ago by epertoso
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix Allocate macro in the CodeStubAssembler. The macro was Using SmiTag(Int32Constant()) was causing some unnecessary shifts to be emitted in the deferred code. Also, when allocating in new space, the macro now uses Runtime::kAllocateInNewSpace. Committed: https://crrev.com/46907cbbab52530e7767f864b2b623ba2bd021fa Cr-Commit-Position: refs/heads/master@{#36023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
epertoso
4 years, 7 months ago (2016-05-04 12:13:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945263002/1
4 years, 7 months ago (2016-05-04 12:13:40 UTC) #4
Benedikt Meurer
Nice. LGTM.
4 years, 7 months ago (2016-05-04 12:15:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 12:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945263002/1
4 years, 7 months ago (2016-05-04 12:45:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:47:29 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:48:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46907cbbab52530e7767f864b2b623ba2bd021fa
Cr-Commit-Position: refs/heads/master@{#36023}

Powered by Google App Engine
This is Rietveld 408576698