[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280, v8:4853
LOG=N

Committed: https://crrev.com/a64b1d876797f9824d3b31cd9ba8f43f284b783e
Cr-Commit-Position: refs/heads/master@{#36098}

[mythria, 2016-05-04 09:07:05]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 09:07:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945223002/1

[commit-bot: I haz the power, 2016-05-04 09:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 09:27:18]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[mythria, 2016-05-04 11:05:33]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 11:05:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945223002/20001

[commit-bot: I haz the power, 2016-05-04 11:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 11:21:31]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[mythria, 2016-05-04 12:59:25]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 12:59:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945223002/40001

[commit-bot: I haz the power, 2016-05-04 13:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 13:28:31]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-05-04 13:45:53]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections does not work with ignition because dead
registers are not cleared. The cost of clearing the dead registers will
outweigh its benefits. Hence dead registers will not be cleared. Modifying
this test to work with ignition.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead
registers may hold references to objects. GC will believe they are live
and does not collect them. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying
this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

[mythria, 2016-05-04 13:48:49]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead
registers may hold references to objects. GC will believe they are live
and does not collect them. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying
this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead
registers may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying
this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

[mythria, 2016-05-04 13:49:40]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead
registers may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying
this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

[mythria, 2016-05-04 13:50:02]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test
to work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

[mythria, 2016-05-04 13:50:46]

mythria@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[mythria, 2016-05-04 13:50:47]

PTAL.

Thanks,
Mythri

[rmcilroy, 2016-05-04 14:36:50]

https://codereview.chromium.org/1945223002/diff/40001/test/mjsunit/es6/mirror...
File test/mjsunit/es6/mirror-collections.js (right):

https://codereview.chromium.org/1945223002/diff/40001/test/mjsunit/es6/mirror...
test/mjsunit/es6/mirror-collections.js:108:
assertTrue(getWeakMapLength(weakMapMirror) <= 5);
I think it would be cleaner just to wrap all the set code in a single function,
e.g.:

function initWeakMapEntries(weakMap) {
  weakMap.set(o1, 11);
  ...
  return weakMapMirror;
}

var weakMap = new WeakMap();
var weakMapMirror = initWeakMapEntries(weakMap);
gc();

WDYT?

[mythria, 2016-05-04 15:41:31]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 15:41:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945223002/60001

[mythria, 2016-05-04 16:13:57]

https://codereview.chromium.org/1945223002/diff/40001/test/mjsunit/es6/mirror...
File test/mjsunit/es6/mirror-collections.js (right):

https://codereview.chromium.org/1945223002/diff/40001/test/mjsunit/es6/mirror...
test/mjsunit/es6/mirror-collections.js:108:
assertTrue(getWeakMapLength(weakMapMirror) <= 5);
On 2016/05/04 14:36:50, rmcilroy wrote:
> I think it would be cleaner just to wrap all the set code in a single
function,
> e.g.:
> 
> function initWeakMapEntries(weakMap) {
>   weakMap.set(o1, 11);
>   ...
>   return weakMapMirror;
> }
> 
> var weakMap = new WeakMap();
> var weakMapMirror = initWeakMapEntries(weakMap);
> gc();
> 
> WDYT?

Thanks, it looks much cleaner. Done.

[commit-bot: I haz the power, 2016-05-04 16:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 16:21:25]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-05-05 08:52:17]

mythria@chromium.org changed reviewers:
+ yangguo@chromium.org

[mythria, 2016-05-05 08:52:18]

Hi Yang,

I updated mjsunit/es6/mirror-collections test to work with ignition. We have
decided not to clear dead registers since it is expensive and does not have
significant impact on heap size. PTAL.

Thanks,
Mythri

[rmcilroy, 2016-05-05 09:23:55]

LGTM if Yang agrees.

[Yang, 2016-05-09 05:36:35]

On 2016/05/05 09:23:55, rmcilroy wrote:
> LGTM if Yang agrees.

LGTM.

[mythria, 2016-05-09 08:14:41]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-05-09 08:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945223002/60001

[commit-bot: I haz the power, 2016-05-09 08:38:33]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

[commit-bot: I haz the power, 2016-05-09 08:38:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-09 08:40:14]

Description was changed from

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280,v8:4853
LOG=N
==========

to

==========
[Interpreter] Updates mjsunit/es6/mirror-collections to work with ignition

mjsunit/es6/mirror-collections fails with ignition because dead registers
may hold references to objects. This prevents GC from collecting
otherwise dead objects. Dead registers are not cleared because the cost
of clearing them outweighs its benefits. Hence, modifying this test to
work around this problem.

BUG=v8:4280,v8:4853
LOG=N

Committed: https://crrev.com/a64b1d876797f9824d3b31cd9ba8f43f284b783e
Cr-Commit-Position: refs/heads/master@{#36098}
==========

[commit-bot: I haz the power, 2016-05-09 08:40:15]

Patchset 4 (id:??) landed as
https://crrev.com/a64b1d876797f9824d3b31cd9ba8f43f284b783e
Cr-Commit-Position: refs/heads/master@{#36098}