Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1945203002: [css-grid] Refactor code to manage positioned items (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Refactor code to manage positioned items Refactoring of LayoutGrid::offsetAndBreadthForPositionedChild() that became really complex after adding RTL support for positioned items. No new tests, no change of behavior. BUG=273898 Committed: https://crrev.com/60077d7e66ae6b7b37202065560f28811fc64b56 Cr-Commit-Position: refs/heads/master@{#391495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 2 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Manuel Rego
4 years, 7 months ago (2016-05-04 08:20:51 UTC) #2
svillar
lgtm
4 years, 7 months ago (2016-05-04 10:33:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945203002/1
4 years, 7 months ago (2016-05-04 10:44:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 13:41:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60077d7e66ae6b7b37202065560f28811fc64b56 Cr-Commit-Position: refs/heads/master@{#391495}
4 years, 7 months ago (2016-05-04 13:43:07 UTC) #8
cbiesinger
4 years, 7 months ago (2016-05-04 22:32:37 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698