Issue 19452002: roll gyp 1675:1678

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19452002: roll gyp 1675:1678 (Closed)

Created:
7 years, 5 months ago by Nico

Modified:
7 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, alexeypa (please no reviews), Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll gyp 1675:1678 1676: msvs: Add Visual Studio 2013 support. 1677: ninja/win: Fixed "RC4011: identifier truncated" warning. 1678: ninja&make/mac: Implement GCC_STRICT_ALIASING support. Also switch build/common.gypi to GCC_STRICT_ALIASING instead of passing '-fno-strict-aliasing' via OTHER_CFLAGS. BUG=260800 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211878

Patch Set 1 #

Patch Set 2 : roll gyp 1675:1678 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/common.gypi	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm, you're racing alexeypa again here https://codereview.chromium.org/19374005/

7 years, 5 months ago (2013-07-16 23:54:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/19452002/2001

7 years, 5 months ago (2013-07-17 00:09:36 UTC) #4

Nico

7 years, 5 months ago (2013-07-17 00:12:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r211878 (presubmit successful).

Expand Messages | Collapse Messages