Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1945193002: [profiler] sampled allocations should be marked as independent (Closed)

Created:
4 years, 7 months ago by ofrobots
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] sampled allocations should be marked as independent Sampling heap profiler keeps weak references. These should be marked independent so that the weak callback can be dispatched on new space collections. BUG=v8:4959 LOG=N R=ulan@chromium.org Committed: https://crrev.com/9622696b5e225ca642f9ea88c0473d59cde062c2 Cr-Commit-Position: refs/heads/master@{#36012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/profiler/sampling-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945193002/1
4 years, 7 months ago (2016-05-04 08:19:12 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 08:42:27 UTC) #4
ulan
lgtm
4 years, 7 months ago (2016-05-04 09:38:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945193002/1
4 years, 7 months ago (2016-05-04 09:53:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 09:58:21 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 09:59:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9622696b5e225ca642f9ea88c0473d59cde062c2
Cr-Commit-Position: refs/heads/master@{#36012}

Powered by Google App Engine
This is Rietveld 408576698