Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945183006: Fix DBC product build (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M runtime/vm/simulator_dbc.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gyp/configurations.gypi View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 7 months ago (2016-05-05 22:26:23 UTC) #2
rmacnak
lgtm w/c https://chromiumcodereview.appspot.com/1945183006/diff/1/runtime/vm/stub_code_dbc.cc File runtime/vm/stub_code_dbc.cc (left): https://chromiumcodereview.appspot.com/1945183006/diff/1/runtime/vm/stub_code_dbc.cc#oldcode31 runtime/vm/stub_code_dbc.cc:31: DECLARE_FLAG(bool, lazy_dispatchers); optimization_counter_threshold and lazy_dispatchers were also ...
4 years, 7 months ago (2016-05-05 22:46:48 UTC) #3
zra
https://chromiumcodereview.appspot.com/1945183006/diff/1/runtime/vm/stub_code_dbc.cc File runtime/vm/stub_code_dbc.cc (left): https://chromiumcodereview.appspot.com/1945183006/diff/1/runtime/vm/stub_code_dbc.cc#oldcode31 runtime/vm/stub_code_dbc.cc:31: DECLARE_FLAG(bool, lazy_dispatchers); On 2016/05/05 22:46:48, rmacnak wrote: > optimization_counter_threshold ...
4 years, 7 months ago (2016-05-05 22:57:11 UTC) #4
zra
4 years, 7 months ago (2016-05-05 22:57:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
78de302495ad5470da30dc7337e15d4ec7c7ee40.

Powered by Google App Engine
This is Rietveld 408576698