Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1945183002: Fix missing functionality with --allow-native-extensions (Closed)

Created:
4 years, 7 months ago by sigurdm
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M pkg/compiler/lib/src/native/native.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 2 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sigurdm
This seems to have been left out at b887563dff1ed69e32bb9a7d8cb2a18bab57774c
4 years, 7 months ago (2016-05-04 07:45:32 UTC) #2
Johnni Winther
lgtm
4 years, 7 months ago (2016-05-04 08:51:06 UTC) #3
sigurdm
4 years, 7 months ago (2016-05-04 08:53:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e47e8af36491eb883c14641c8587e9b0ee4a805b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698