Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945103003: Rename VulkanViewer to Viewer, take 2. (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
Reviewers:
bsalomon, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename VulkanViewer to Viewer, take 2. Also puts Window and Application in sk_app namespace. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1945103003 Committed: https://skia.googlesource.com/skia/+/345242671587d7273819bfe423be96e4392033e3

Patch Set 1 #

Patch Set 2 : Fix android path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -2601 lines) Patch
M gyp/most.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
A + gyp/viewer.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D gyp/vulkanviewer.gyp View 1 chunk +0 lines, -68 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +1 line, -1 line 0 comments Download
A + platform_tools/android/apps/viewer/build.gradle View 2 chunks +2 lines, -2 lines 0 comments Download
A + platform_tools/android/apps/viewer/src/main/AndroidManifest.xml View 1 chunk +5 lines, -5 lines 0 comments Download
A + platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
D platform_tools/android/apps/vulkanviewer/build.gradle View 1 chunk +0 lines, -24 lines 0 comments Download
D platform_tools/android/apps/vulkanviewer/src/main/AndroidManifest.xml View 1 chunk +0 lines, -26 lines 0 comments Download
D platform_tools/android/apps/vulkanviewer/src/main/java/org/skia/vulkanviewer/VulkanViewerActivity.java View 1 chunk +0 lines, -28 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
A platform_tools/android/gyp/viewer.gypi View 1 1 chunk +65 lines, -0 lines 0 comments Download
D platform_tools/android/gyp/vulkanviewer.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
A + tools/viewer/Application.h View 2 chunks +4 lines, -0 lines 0 comments Download
A + tools/viewer/VulkanTestContext.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/VulkanTestContext.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/Window.h View 2 chunks +3 lines, -1 line 0 comments Download
A + tools/viewer/Window.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
A + tools/viewer/android/VulkanTestContext_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/android/VulkanTestContext_android.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/android/Window_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
A + tools/viewer/android/Window_android.cpp View 4 chunks +6 lines, -2 lines 0 comments Download
A + tools/viewer/android/main_android.cpp View 2 chunks +3 lines, -1 line 0 comments Download
A + tools/viewer/viewer/GMSlide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/viewer/GMSlide.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/viewer/SKPSlide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/viewer/SKPSlide.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/viewer/Slide.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/viewer/Viewer.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + tools/viewer/viewer/Viewer.cpp View 13 chunks +20 lines, -18 lines 0 comments Download
A + tools/viewer/win/VulkanTestContext_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/win/VulkanTestContext_win.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/viewer/win/Window_win.h View 2 chunks +4 lines, -0 lines 0 comments Download
A + tools/viewer/win/Window_win.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
A + tools/viewer/win/main_win.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
D tools/vulkan/Application.h View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/vulkan/VulkanTestContext.h View 1 chunk +0 lines, -114 lines 0 comments Download
D tools/vulkan/VulkanTestContext.cpp View 1 chunk +0 lines, -568 lines 0 comments Download
D tools/vulkan/Window.h View 1 chunk +0 lines, -148 lines 0 comments Download
D tools/vulkan/Window.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D tools/vulkan/android/VulkanTestContext_android.h View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/vulkan/android/VulkanTestContext_android.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/vulkan/android/Window_android.h View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/vulkan/android/Window_android.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D tools/vulkan/android/main_android.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D tools/vulkan/viewer/GMSlide.h View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/vulkan/viewer/GMSlide.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/vulkan/viewer/SKPSlide.h View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/vulkan/viewer/SKPSlide.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/vulkan/viewer/Slide.h View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/vulkan/viewer/VulkanViewer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D tools/vulkan/viewer/VulkanViewer.cpp View 1 chunk +0 lines, -344 lines 0 comments Download
D tools/vulkan/win/VulkanTestContext_win.h View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/vulkan/win/VulkanTestContext_win.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/vulkan/win/Window_win.h View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/vulkan/win/Window_win.cpp View 1 chunk +0 lines, -281 lines 0 comments Download
D tools/vulkan/win/main_win.cpp View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
Second try at this (the other was polluted with tabs, beyond saving).
4 years, 7 months ago (2016-05-04 19:59:42 UTC) #3
bsalomon
lgtm
4 years, 7 months ago (2016-05-04 20:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945103003/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945103003/2
4 years, 7 months ago (2016-05-04 20:29:34 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:49:16 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:2) as
https://skia.googlesource.com/skia/+/345242671587d7273819bfe423be96e4392033e3

Powered by Google App Engine
This is Rietveld 408576698