Go bindings: Don't import 'fmt' unless it is needed.

Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug in mojom_go_generator.py
regarding when to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.

R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6a329476c90cc8ea18d52251555783e11a0915fe

[rudominer, 2016-05-04 01:08:42]

Description was changed from

==========
Go bindings:  Don't include 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug regarding when
to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

to

==========
Go bindings: Don't generate import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug regarding when
to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

[rudominer, 2016-05-04 01:09:39]

Description was changed from

==========
Go bindings: Don't generate import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug regarding when
to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

to

==========
Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug regarding when
to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

[rudominer, 2016-05-04 01:10:16]

Description was changed from

==========
Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug regarding when
to import the 'fmt' package (and also the mojo/public/go/bindings package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

to

==========
Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug in
mojom_go_generator.py
regarding when to import the 'fmt' package (and also the mojo/public/go/bindings
package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

[rudominer, 2016-05-04 01:18:18]

Patchset #1 (id:1) has been deleted

[rudominer, 2016-05-04 01:18:25]

Patchset #1 (id:20001) has been deleted

[rudominer, 2016-05-04 01:32:03]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org, vardhan@google.com

[rudominer, 2016-05-04 01:32:04]

Hi Alex and Vardhan, ptal.

The problem I'm fixing was mentioned here:
https://github.com/domokit/mojo/commit/2f2d1bece6eb2dae607edadbc7355cec65e892...

[azani, 2016-05-04 01:39:49]

lgtm

[rudominer, 2016-05-04 01:42:43]

Description was changed from

==========
Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug in
mojom_go_generator.py
regarding when to import the 'fmt' package (and also the mojo/public/go/bindings
package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.
==========

to

==========
Go bindings: Don't import 'fmt' unless it is needed.

In https://codereview.chromium.org/1943643002/ I introduced a bug in
mojom_go_generator.py
regarding when to import the 'fmt' package (and also the mojo/public/go/bindings
package)
into the generated Go code. I knew there was an additional case where it
needed to be added but I thought it was the case where a .mojom file had
only enums and nothing else. But it turns out it was the case where
that was true and we are generating runtime type info because the flag
generate_type_info=true. It turns out just checking for this latter condition
is sufficient.

The reason I hadn't caught this was that we didn't have a test where runtime
type info was not being generated. I have now added one.

R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/6a329476c90cc8ea18d52251555...
==========

[rudominer, 2016-05-04 01:42:45]

Committed patchset #1 (id:40001) manually as
6a329476c90cc8ea18d52251555783e11a0915fe (presubmit successful).