Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 194503004: Move ParseArguments to ParserBase and add tests. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Move ParseArguments to ParserBase and add tests. Notes: - PreParser didn't produce "too_many_arguments"; now it does. - The argument count in the error message was wrong; fixed it. BUG=v8:3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19812

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : done #

Patch Set 4 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -57 lines) Patch
M src/messages.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M src/preparser.h View 1 2 9 chunks +55 lines, -6 lines 0 comments Download
M src/preparser.cc View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 5 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
ulan, pls review this small one too.
6 years, 9 months ago (2014-03-11 13:42:58 UTC) #1
ulan
lgtm https://codereview.chromium.org/194503004/diff/20001/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/194503004/diff/20001/src/preparser.h#newcode1503 src/preparser.h:1503: if (!done) Expect(Token::COMMA, CHECK_OK_CUSTOM(NullExpressionList)); As discussed offline, it ...
6 years, 9 months ago (2014-03-11 15:39:58 UTC) #2
marja
thx for review & good catch! https://codereview.chromium.org/194503004/diff/20001/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/194503004/diff/20001/src/preparser.h#newcode1503 src/preparser.h:1503: if (!done) Expect(Token::COMMA, ...
6 years, 9 months ago (2014-03-11 15:49:10 UTC) #3
marja
6 years, 9 months ago (2014-03-11 16:30:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r19812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698