Issue 194503002: Remove SnapshotFillerInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194503002: Remove SnapshotFillerInterface (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, Michael Starzinger, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove SnapshotFillerInterface There used to be additional pass in the heap profiler that estimated memory required for the snapshot and it used special implementation of the interface. Now that we dropped that step it doesn't makes sense to keep the interface with single implementation. BUG=None LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19875

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -95 lines)			Patch
	M	src/heap-snapshot-generator.h	View		6 chunks	+7 lines, -32 lines	0 comments	Download
	M	src/heap-snapshot-generator.cc	View		5 chunks	+63 lines, -63 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (rubber-stamped). Sorry for delay, fell through cracks.

6 years, 9 months ago (2014-03-12 09:17:56 UTC) #5

yurys

6 years, 9 months ago (2014-03-13 07:49:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r19875 (presubmit successful).

Expand Messages | Collapse Messages