Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1945023003: [turbofan] Don't need any write barrier when storing maps from the root set. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't need any write barrier when storing maps from the root set. Maps that are immortal immovable (i.e. the one pointer filler map) don't need write barriers. R=jarin@chromium.org Committed: https://crrev.com/e93f06ad877abe9c109b9c158a9c1bac73be536f Cr-Commit-Position: refs/heads/master@{#36016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-04 11:16:33 UTC) #1
Benedikt Meurer
Hey Jaro, Quick fix. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-04 11:17:23 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-04 11:19:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945023003/1
4 years, 7 months ago (2016-05-04 11:20:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 11:41:05 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 11:43:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e93f06ad877abe9c109b9c158a9c1bac73be536f
Cr-Commit-Position: refs/heads/master@{#36016}

Powered by Google App Engine
This is Rietveld 408576698