Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1945013002: Turn on using SDK summaries in the command line analyzer. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn on using SDK summaries in the command line analyzer. We pass all of the shared tests now. We used to pass too, but there was a couple small regressions. The regressions have been fixed, so if you don't see a reason not to turn using summaries on, I think we could do this. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d7f14a639da2cd93d768852d9f951076afcf1e4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-03 21:58:31 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-03 22:01:57 UTC) #2
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-03 22:02:40 UTC) #3
scheglov
4 years, 7 months ago (2016-05-03 22:15:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7f14a639da2cd93d768852d9f951076afcf1e4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698