Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1944993003: Move most of FontRenderStyle manipulation code into its own file (Closed)

Created:
4 years, 7 months ago by tzik
Modified:
4 years, 7 months ago
Reviewers:
haraken, eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-style_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move most of FontRenderStyle manipulation code into its own file This CL isolates FontPlatformData::m_style handling into its method, so that m_style is easy to move from FontPlatformData to SimpleFontData. BUG=608650 Committed: https://crrev.com/fe669432f4eca6a0948012858b459fd2631a72da Cr-Commit-Position: refs/heads/master@{#392494}

Patch Set 1 #

Patch Set 2 : android fix #

Patch Set 3 : windows fix #

Patch Set 4 : more typo fix #

Messages

Total messages: 38 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/1
4 years, 7 months ago (2016-05-04 09:08:13 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/61123)
4 years, 7 months ago (2016-05-04 09:27:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/20001
4 years, 7 months ago (2016-05-04 09:43:04 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/132196)
4 years, 7 months ago (2016-05-04 10:31:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/40001
4 years, 7 months ago (2016-05-04 11:02:22 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/142864)
4 years, 7 months ago (2016-05-04 11:52:54 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/60001
4 years, 7 months ago (2016-05-09 07:53:24 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/134033) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 7 months ago (2016-05-09 07:56:59 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/60001
4 years, 7 months ago (2016-05-09 08:59:59 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225408)
4 years, 7 months ago (2016-05-09 09:58:57 UTC) #21
tzik
PTAL
4 years, 7 months ago (2016-05-09 14:12:56 UTC) #24
eae
LGTM
4 years, 7 months ago (2016-05-09 15:35:56 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/60001
4 years, 7 months ago (2016-05-09 15:36:19 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/179667)
4 years, 7 months ago (2016-05-09 15:43:14 UTC) #29
tzik
Haraken-san, could you PTAL to Source/web part as an owner?
4 years, 7 months ago (2016-05-09 23:29:21 UTC) #31
haraken
On 2016/05/09 23:29:21, tzik wrote: > Haraken-san, could you PTAL to Source/web part as an ...
4 years, 7 months ago (2016-05-09 23:33:31 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993003/60001
4 years, 7 months ago (2016-05-10 00:35:05 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 00:40:11 UTC) #36
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 00:42:40 UTC) #38
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fe669432f4eca6a0948012858b459fd2631a72da
Cr-Commit-Position: refs/heads/master@{#392494}

Powered by Google App Engine
This is Rietveld 408576698