Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issue 1944993002: Revert of DevTools: fix focus restoration from command menu (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: fix focus restoration from command menu (patchset #4 id:60001 of https://codereview.chromium.org/1922303004/ ) Reason for revert: Breaks focus from Cmd+P Original issue's description: > DevTools: fix focus restoration from command menu > > BUG=604427 > > Committed: https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8 > Cr-Commit-Position: refs/heads/master@{#391057} TBR=dgozman@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604427 Committed: https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42 Cr-Commit-Position: refs/heads/master@{#391356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pfeldman
Created Revert of DevTools: fix focus restoration from command menu
4 years, 7 months ago (2016-05-03 21:14:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944993002/1
4 years, 7 months ago (2016-05-03 21:15:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 21:16:20 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:18:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42
Cr-Commit-Position: refs/heads/master@{#391356}

Powered by Google App Engine
This is Rietveld 408576698