Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1944963002:
media: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION (Closed)
|
Created:
4 years, 7 months ago by watk Modified:
4 years, 7 months ago Reviewers:
liberato (no reviews please) CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION
Previously AVDA was only reporting this capability when deferred
rendering was enabled, but they are orthogonal.
BUG=608581
Committed: https://crrev.com/37452ef6ad139284e11392a6bd7062ab1f18f43f
Cr-Commit-Position: refs/heads/master@{#391576}
Patch Set 1 #
Total comments: 2
Patch Set 2 : comments #Messages
Total messages: 19 (9 generated)
watk@chromium.org changed reviewers: + liberato@chromium.org
lgtm % nit thanks for fixing this thing i broke :) -fl https://codereview.chromium.org/1944963002/diff/1/media/gpu/android_video_dec... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/1944963002/diff/1/media/gpu/android_video_dec... media/gpu/android_video_decode_accelerator.cc:1453: capabilities.flags |= media::VideoDecodeAccelerator::Capabilities:: s/|=/=
The CQ bit was checked by watk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944963002/20001
https://codereview.chromium.org/1944963002/diff/1/media/gpu/android_video_dec... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/1944963002/diff/1/media/gpu/android_video_dec... media/gpu/android_video_decode_accelerator.cc:1453: capabilities.flags |= media::VideoDecodeAccelerator::Capabilities:: On 2016/05/03 21:20:12, liberato wrote: > s/|=/= Done. I also did a sneaky change to move "profile" into each of the profiles blocks above, since it felt dirty that we were reusing it for different codecs.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by watk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from liberato@chromium.org Link to the patchset: https://codereview.chromium.org/1944963002/#ps20001 (title: "comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944963002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944963002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== media: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION Previously AVDA was only reporting this capability when deferred rendering was enabled, but they are orthogonal. BUG=608581 ========== to ========== media: AVDA always reports SUPPORTS_DEFERRED_INITIALIZATION Previously AVDA was only reporting this capability when deferred rendering was enabled, but they are orthogonal. BUG=608581 Committed: https://crrev.com/37452ef6ad139284e11392a6bd7062ab1f18f43f Cr-Commit-Position: refs/heads/master@{#391576} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/37452ef6ad139284e11392a6bd7062ab1f18f43f Cr-Commit-Position: refs/heads/master@{#391576} |
