Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1944913002: S390: [sim] Add icount and si <mnemonic> commands. (Closed)

Created:
4 years, 7 months ago by mcornac
Modified:
4 years, 7 months ago
Reviewers:
john.yan, JoranSiu
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [sim] Add icount and si <mnemonic> commands. Typing icount at the sim debug prompt will print the current icount. si <mnemonic> steps through instructions until an instruction with that mnemonic is seen. E.g. si brc will stop at the next brc instruction before executing it. R=jyan@ca.ibm.com, joransiu@ca.ibm.com Committed: https://crrev.com/4930a16ed3dc5c1d87e4179d25ebda638ce3a140 Cr-Commit-Position: refs/heads/master@{#35997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/s390/simulator-s390.cc View 5 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mcornac
PTAL
4 years, 7 months ago (2016-05-03 19:21:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944913002/1
4 years, 7 months ago (2016-05-03 19:22:02 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-03 19:22:03 UTC) #5
john.yan
lgtm
4 years, 7 months ago (2016-05-03 19:23:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944913002/1
4 years, 7 months ago (2016-05-03 19:24:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 19:57:19 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:58:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4930a16ed3dc5c1d87e4179d25ebda638ce3a140
Cr-Commit-Position: refs/heads/master@{#35997}

Powered by Google App Engine
This is Rietveld 408576698