content/common/push_messaging_messages.h - Issue 1944863002: Push API: Fix stored sender ID being out of sync with registration ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 1944863002: Push API: Fix stored sender ID being out of sync with registration ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ii7swdb

Patch Set: Add TODO Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index df88b2f2a552f86ab65fa25563af10b709b9247a..f3710684a3d82fb1d79f524058293f8b8e8a6f47 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -86,14 +86,11 @@ IPC_MESSAGE_CONTROL2(PushMessagingMsg_GetPermissionStatusError,

// Messages sent from the child process to the browser.

-IPC_MESSAGE_CONTROL4(PushMessagingHostMsg_SubscribeFromDocument,

+// |render_frame_id| should be ChildProcessHost::kInvalidUniqueID for requests

+// from a Service Worker.

+IPC_MESSAGE_CONTROL4(PushMessagingHostMsg_Subscribe,

int32_t /* render_frame_id */,

int32_t /* request_id */,

- content::PushSubscriptionOptions /* options */,

- int64_t /* service_worker_registration_id */)

-IPC_MESSAGE_CONTROL3(PushMessagingHostMsg_SubscribeFromWorker,

- int32_t /* request_id */,

int64_t /* service_worker_registration_id */,

content::PushSubscriptionOptions /* options */)

« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »