Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1944853002:
[DevTools] Security Panel: Use actual origin as textContent for title element. (Closed)
|
Created:
4 years, 7 months ago by mmccoy Modified:
4 years, 7 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Security Panel: Use actual origin as textContent for title element.
BUG=594856
Committed: https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39
Cr-Commit-Position: refs/heads/master@{#391864}
Patch Set 1 #Patch Set 2 : Updated style #
Messages
Total messages: 22 (8 generated)
mmccoy@google.com changed reviewers: + dgozman@chromium.org, lgarron@chromium.org, mmccoy@google.com, paulirish@chromium.org
PTAL, thanks! (Screenshot in monorail issue thread)
On 2016/05/03 at 18:16:31, mmccoy1 wrote: > PTAL, thanks! (Screenshot in monorail issue thread) https://screenshot.googleplex.com/kR34Azo9CFn
On 2016/05/03 at 18:16:53, mmccoy wrote: > On 2016/05/03 at 18:16:31, mmccoy1 wrote: > > PTAL, thanks! (Screenshot in monorail issue thread) > > https://screenshot.googleplex.com/kR34Azo9CFn LGTM; thanks for taking this on!
The CQ bit was checked by mmccoy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Oops, need owners. dgozman, PTAL at your convenience. Thx.
lgtm, but we should migrate security to the ReportView for consistent styling.
On 2016/05/05 at 16:45:37, pfeldman wrote: > lgtm, but we should migrate security to the ReportView for consistent styling. Thanks for looking. I'm not sure what it entails, but I'm happy to look at doing that in the near future. -mm
The CQ bit was checked by mmccoy@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by mmccoy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lgarron@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1944853002/#ps20001 (title: "Updated style")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944853002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Security Panel: Use actual origin as textContent for title element. BUG=594856 ========== to ========== [DevTools] Security Panel: Use actual origin as textContent for title element. BUG=594856 Committed: https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39 Cr-Commit-Position: refs/heads/master@{#391864} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39 Cr-Commit-Position: refs/heads/master@{#391864}
Message was sent while issue was closed.
On 2016/05/05 19:05:46, commit-bot: I haz the power wrote:
> <font><font class="">Nghĩa patchset 2 (id: ??) đã hạ cánh như
>
</font></font>https://crrev.com/d8a506c092f85ee69272136f0b4e3af915a09f39<font><font
class="">
> Cr-Cam-Position: refs / con / tổng @ {# 391.864}</font></font>
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
