Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 194483002: PromiseCoerce should deal with an error during accessing "then". (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

PromiseCoerce should deal with an error during accessing "then". PromiseCource(x) should return a rejected promise when accessing x.then leads to an error. BUG=347095 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19928

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/promise.js View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
6 years, 9 months ago (2014-03-12 04:54:56 UTC) #1
yhirano
PTAL
6 years, 9 months ago (2014-03-12 08:47:31 UTC) #2
yhirano
PTAL again
6 years, 9 months ago (2014-03-14 10:25:11 UTC) #3
rossberg
lgtm
6 years, 9 months ago (2014-03-14 10:32:02 UTC) #4
rossberg
6 years, 9 months ago (2014-03-14 10:35:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698