Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944813002: Fix MakeWeak and IsWeakRetainer for global handles with finalizers. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix MakeWeak and IsWeakRetainer for global handles with finalizers. BUG= Committed: https://crrev.com/566c825d4a7760351862b8bcfd59303442c1d635 Cr-Commit-Position: refs/heads/master@{#36019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/global-handles.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 7 months ago (2016-05-03 17:55:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:53:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944813002/1
4 years, 7 months ago (2016-05-04 11:27:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 11:56:22 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 11:58:46 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/566c825d4a7760351862b8bcfd59303442c1d635
Cr-Commit-Position: refs/heads/master@{#36019}

Powered by Google App Engine
This is Rietveld 408576698