Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1944793002: Deprecate PersistentBase::MarkPartiallyDependent. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate PersistentBase::MarkPartiallyDependent. It is already effectively disabled by --scavenge_reclaim_unmodified_objects. BUG= Committed: https://crrev.com/d441100b70acbe19b439c76c0159b2bf758aec4a Cr-Commit-Position: refs/heads/master@{#36018}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -121 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +0 lines, -120 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
ptal
4 years, 7 months ago (2016-05-03 17:17:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:52:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944793002/40001
4 years, 7 months ago (2016-05-04 11:26:40 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 11:55:02 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 11:56:28 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d441100b70acbe19b439c76c0159b2bf758aec4a
Cr-Commit-Position: refs/heads/master@{#36018}

Powered by Google App Engine
This is Rietveld 408576698