Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1944773002: Support references to top level getters in the summary linker. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support references to top level getters in the summary linker. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f72f1e00b6b1ee7b55e3b94d596f059c8e834531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -5 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 7 chunks +45 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-03 16:50:54 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-03 19:16:29 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-03 19:22:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f72f1e00b6b1ee7b55e3b94d596f059c8e834531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698