third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp - Issue 1944623002: CC Animation: Use ElementId to attach CC animation players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids

Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('K') | « third_party/WebKit/Source/web/LinkHighlightImpl.cpp ('k') | ui/compositor/layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

index bec1d2b4abd17cc4431876b812c3100a4b6bfdd4..42ef0a3603c099e5d35f099a9f053d1e73d19111 100644

--- a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

+++ b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

@@ -177,11 +177,9 @@ TEST_F(CompositorWorkerTest, noProxies)

Element* scrollElement = document->getElementById("proxied-scroller");

WebLayer* scrollLayer = scrollingWebLayerFromElement(scrollElement);

EXPECT_FALSE(!!scrollLayer->compositorMutableProperties());

- EXPECT_EQ(0, scrollLayer->elementId());

WebLayer* rootScrollLayer = getRootScrollLayer();

EXPECT_FALSE(!!rootScrollLayer->compositorMutableProperties());

- EXPECT_EQ(0, rootScrollLayer->elementId());

}

TEST_F(CompositorWorkerTest, disconnectedProxies)

@@ -206,11 +204,9 @@ TEST_F(CompositorWorkerTest, disconnectedProxies)