Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4689)

Unified Diff: cc/layers/layer_impl.cc

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids
Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index 46bcf24239ba6004d1e7ff2047120ddb613e5996..2a1ce1868401186f4d4b2d75d95620ae921c19d1 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -88,6 +88,11 @@ LayerImpl::LayerImpl(LayerTreeImpl* tree_impl, int id)
DCHECK(layer_tree_impl_);
layer_tree_impl_->RegisterLayer(this);
+ // TODO(loyso): Pass element_id_ via constructor.
+ // Note that since element_id_ is zero here, calling RegisterLayerForElementId
+ // and AddToElementMap is a matter of elegance/symmetry. See SetElementId.
+ if (element_id())
+ layer_tree_impl_->RegisterLayerForElementId(this);
layer_tree_impl_->AddToElementMap(this);
SetNeedsPushProperties();
@@ -99,10 +104,13 @@ LayerImpl::~LayerImpl() {
if (!copy_requests_.empty() && layer_tree_impl_->IsActiveTree())
layer_tree_impl()->RemoveLayerWithCopyOutputRequest(this);
layer_tree_impl_->UnregisterScrollLayer(this);
- layer_tree_impl_->UnregisterLayer(this);
- layer_tree_impl_->RemoveLayerShouldPushProperties(this);
layer_tree_impl_->RemoveFromElementMap(this);
+ if (element_id())
+ layer_tree_impl_->UnregisterLayerForElementId(this);
+ layer_tree_impl_->UnregisterLayer(this);
+
+ layer_tree_impl_->RemoveLayerShouldPushProperties(this);
TRACE_EVENT_OBJECT_DELETED_WITH_ID(
TRACE_DISABLED_BY_DEFAULT("cc.debug"), "cc::LayerImpl", this);
@@ -388,7 +396,13 @@ void LayerImpl::SetScrollClipLayer(int scroll_clip_layer_id) {
return;
layer_tree_impl()->UnregisterScrollLayer(this);
+ if (element_id())
+ layer_tree_impl()->UnregisterLayerForElementId(this);
+
scroll_clip_layer_id_ = scroll_clip_layer_id;
+
+ if (element_id())
+ layer_tree_impl()->RegisterLayerForElementId(this);
layer_tree_impl()->RegisterScrollLayer(this);
}
@@ -1005,8 +1019,15 @@ void LayerImpl::SetElementId(ElementId element_id) {
"LayerImpl::SetElementId", "id", element_id);
layer_tree_impl_->RemoveFromElementMap(this);
+ if (element_id_)
+ layer_tree_impl_->UnregisterLayerForElementId(this);
+
element_id_ = element_id;
+
layer_tree_impl_->AddToElementMap(this);
+ if (element_id_)
+ layer_tree_impl_->RegisterLayerForElementId(this);
+
SetNeedsPushProperties();
}

Powered by Google App Engine
This is Rietveld 408576698