cc/animation/element_animations.cc - Issue 1944623002: CC Animation: Use ElementId to attach CC animation players.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/element_animations.cc

Issue 1944623002: CC Animation: Use ElementId to attach CC animation players. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasedomids

Patch Set: Let CC clients generate their own ElementIds locally. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/element_animations.cc

diff --git a/cc/animation/element_animations.cc b/cc/animation/element_animations.cc

index be4b9687d99075a6e8b8aa7cc5c3bdb9e74e164b..32b6366e7a6a951873b91230645fbc2b7b6b8e73 100644

--- a/cc/animation/element_animations.cc

+++ b/cc/animation/element_animations.cc

@@ -567,6 +567,7 @@ void ElementAnimations::PushNewAnimationsToImplThread(

} else {

// The owning layer isn't yet in the active tree, so the main thread

// scroll offset will be up-to-date.

+ DCHECK(has_element_in_active_list());

current_scroll_offset = ScrollOffsetForAnimation();

}

animations_[i]->curve()->ToScrollOffsetAnimationCurve()->SetInitialValue(

« no previous file with comments | « cc/animation/animation_player_unittest.cc ('k') | cc/animation/element_animations_unittest.cc » ('j') | cc/trees/layer_tree_host.cc » ('J')