CC Animation: Use ElementId to attach CC animation players.

cc/trees/layer_tree_host.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 1250 matching lines @@
 
 SurfaceSequence LayerTreeHost::CreateSurfaceSequence() {
   return SurfaceSequence(surface_id_namespace_, next_surface_sequence_++);
 }
 
 Layer* LayerTreeHost::LayerById(int id) const {
   LayerIdMap::const_iterator iter = layer_id_map_.find(id);
   return iter != layer_id_map_.end() ? iter->second : NULL;
 }
 
+Layer* LayerTreeHost::LayerForElementId(ElementId element_id) const {
+  auto iter = element_id_to_layer_map_.find(element_id);
+  return iter != element_id_to_layer_map_.end() ? iter->second.main : nullptr;
+}
+
+Layer* LayerTreeHost::ScrollLayerForElementId(ElementId element_id) const {
+  auto iter = element_id_to_layer_map_.find(element_id);
+  return iter != element_id_to_layer_map_.end() ? iter->second.scroll : nullptr;

[esprehn, 2016/05/10 22:55:13]

this could just be tracked inside blink and accessed through a delegate or
something?

client_->FindLayerById(element_id)

and blink can do
DOMNodeIds::get(element_id)->layoutObject()->compositedLayerMapping()->layer()
or whatever.

[loyso (OOO), 2016/05/12 06:02:15]

We definitely can't do this:
1) In impl compositor thread;
2) In Aura compositor (that's another client of CC)

+}
+
 void LayerTreeHost::AddLayerShouldPushProperties(Layer* layer) {
   layers_that_should_push_properties_.insert(layer);
 }
 
 void LayerTreeHost::RemoveLayerShouldPushProperties(Layer* layer) {
   layers_that_should_push_properties_.erase(layer);
 }
 
 std::unordered_set<Layer*>& LayerTreeHost::LayersThatShouldPushProperties() {
   return layers_that_should_push_properties_;
 }
 
 bool LayerTreeHost::LayerNeedsPushPropertiesForTesting(Layer* layer) {
   return layers_that_should_push_properties_.find(layer) !=
          layers_that_should_push_properties_.end();
 }
 
 void LayerTreeHost::RegisterLayer(Layer* layer) {
   DCHECK(!LayerById(layer->id()));
   DCHECK(!in_paint_layer_contents_);
   layer_id_map_[layer->id()] = layer;
-  animation_host_->RegisterElement(layer->id(), ElementListType::ACTIVE);
 }
 
 void LayerTreeHost::UnregisterLayer(Layer* layer) {
   DCHECK(LayerById(layer->id()));
   DCHECK(!in_paint_layer_contents_);
-  animation_host_->UnregisterElement(layer->id(), ElementListType::ACTIVE);
   RemoveLayerShouldPushProperties(layer);
   layer_id_map_.erase(layer->id());
 }
 
+void LayerTreeHost::RegisterLayerForElementId(Layer* layer) {
+  DCHECK(layer->element_id());
+  ElementLayers& element_layers = element_id_to_layer_map_[layer->element_id()];
+  if (layer->scrollable()) {
+    DCHECK(!element_layers.scroll);
+    element_layers.scroll = layer;
+  } else {
+    DCHECK(!element_layers.main);
+    element_layers.main = layer;
+  }
+  animation_host_->RegisterElement(layer->element_id(),
+                                   ElementListType::ACTIVE);
+}
+
+void LayerTreeHost::UnregisterLayerForElementId(Layer* layer) {
+  DCHECK(layer->element_id());
+  animation_host_->UnregisterElement(layer->element_id(),
+                                     ElementListType::ACTIVE);
+
+  auto iter = element_id_to_layer_map_.find(layer->element_id());
+  if (iter == element_id_to_layer_map_.end())
+    return;
+
+  ElementLayers& element_layers = iter->second;
+  if (layer->scrollable()) {
+    DCHECK_EQ(element_layers.scroll, layer);
+    element_layers.scroll = nullptr;
+  } else {
+    DCHECK_EQ(element_layers.main, layer);
+    element_layers.main = nullptr;
+  }
+
+  if (!element_layers.main && !element_layers.scroll)
+    element_id_to_layer_map_.erase(layer->element_id());
+}
+
 bool LayerTreeHost::IsElementInList(ElementId element_id,
                                     ElementListType list_type) const {
-  return list_type == ElementListType::ACTIVE && LayerById(element_id);
+  return list_type == ElementListType::ACTIVE &&
+         element_id_to_layer_map_.find(element_id) !=
+             element_id_to_layer_map_.end();
 }
 
 void LayerTreeHost::SetMutatorsNeedCommit() {
   SetNeedsCommit();
 }
 
 void LayerTreeHost::SetMutatorsNeedRebuildPropertyTrees() {
   property_trees_.needs_rebuild = true;
 }
 
 void LayerTreeHost::SetElementFilterMutated(ElementId element_id,
                                             ElementListType list_type,
                                             const FilterOperations& filters) {
-  Layer* layer = LayerById(element_id);
+  Layer* layer = LayerForElementId(element_id);
   DCHECK(layer);
   layer->OnFilterAnimated(filters);
 }
 
 void LayerTreeHost::SetElementOpacityMutated(ElementId element_id,
                                              ElementListType list_type,
                                              float opacity) {
-  Layer* layer = LayerById(element_id);
+  Layer* layer = LayerForElementId(element_id);
   DCHECK(layer);
   layer->OnOpacityAnimated(opacity);
 }
 
 void LayerTreeHost::SetElementTransformMutated(
     ElementId element_id,
     ElementListType list_type,
     const gfx::Transform& transform) {
-  Layer* layer = LayerById(element_id);
+  Layer* layer = LayerForElementId(element_id);
   DCHECK(layer);
   layer->OnTransformAnimated(transform);
 }
 
 void LayerTreeHost::SetElementScrollOffsetMutated(
     ElementId element_id,
     ElementListType list_type,
     const gfx::ScrollOffset& scroll_offset) {
-  Layer* layer = LayerById(element_id);
+  Layer* layer = ScrollLayerForElementId(element_id);
   DCHECK(layer);
   layer->OnScrollOffsetAnimated(scroll_offset);
 }
 
 void LayerTreeHost::ElementTransformIsPotentiallyAnimatingChanged(
     ElementId element_id,
     ElementListType list_type,
     bool is_animating) {
-  Layer* layer = LayerById(element_id);
-  DCHECK(layer);
-  layer->OnTransformIsPotentiallyAnimatingChanged(is_animating);
+  Layer* layer = LayerForElementId(element_id);
+  if (layer)
+    layer->OnTransformIsPotentiallyAnimatingChanged(is_animating);
 }
 
 gfx::ScrollOffset LayerTreeHost::GetScrollOffsetForAnimation(
     ElementId element_id) const {
-  Layer* layer = LayerById(element_id);
+  Layer* layer = ScrollLayerForElementId(element_id);
   DCHECK(layer);
   return layer->ScrollOffsetForAnimation();
 }
 
 bool LayerTreeHost::ScrollOffsetAnimationWasInterrupted(
     const Layer* layer) const {
-  return animation_host_->ScrollOffsetAnimationWasInterrupted(layer->id());
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->ScrollOffsetAnimationWasInterrupted(
+      layer->element_id());
 }
 
 bool LayerTreeHost::IsAnimatingFilterProperty(const Layer* layer) const {
-  return animation_host_->IsAnimatingFilterProperty(layer->id(),
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->IsAnimatingFilterProperty(layer->element_id(),
                                                     ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::IsAnimatingOpacityProperty(const Layer* layer) const {
-  return animation_host_->IsAnimatingOpacityProperty(layer->id(),
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->IsAnimatingOpacityProperty(layer->element_id(),
                                                      ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::IsAnimatingTransformProperty(const Layer* layer) const {
-  return animation_host_->IsAnimatingTransformProperty(layer->id(),
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->IsAnimatingTransformProperty(layer->element_id(),
                                                        ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::HasPotentiallyRunningFilterAnimation(
     const Layer* layer) const {
+  if (!layer->element_id())
+    return false;
+
   return animation_host_->HasPotentiallyRunningFilterAnimation(
-      layer->id(), ElementListType::ACTIVE);
+      layer->element_id(), ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::HasPotentiallyRunningOpacityAnimation(
     const Layer* layer) const {
+  if (!layer->element_id())
+    return false;
+
   return animation_host_->HasPotentiallyRunningOpacityAnimation(
-      layer->id(), ElementListType::ACTIVE);
+      layer->element_id(), ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::HasPotentiallyRunningTransformAnimation(
     const Layer* layer) const {
+  if (!layer->element_id())
+    return false;
+
   return animation_host_->HasPotentiallyRunningTransformAnimation(
-      layer->id(), ElementListType::ACTIVE);
+      layer->element_id(), ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::HasOnlyTranslationTransforms(const Layer* layer) const {
-  return animation_host_->HasOnlyTranslationTransforms(layer->id(),
+  if (!layer->element_id())
+    return true;
+
+  return animation_host_->HasOnlyTranslationTransforms(layer->element_id(),
                                                        ElementListType::ACTIVE);
 }
 
 bool LayerTreeHost::MaximumTargetScale(const Layer* layer,
                                        float* max_scale) const {
+  if (!layer->element_id())
+    return true;
+
   return animation_host_->MaximumTargetScale(
-      layer->id(), ElementListType::ACTIVE, max_scale);
+      layer->element_id(), ElementListType::ACTIVE, max_scale);
 }
 
 bool LayerTreeHost::AnimationStartScale(const Layer* layer,
                                         float* start_scale) const {
+  if (!layer->element_id())
+    return true;
+
   return animation_host_->AnimationStartScale(
-      layer->id(), ElementListType::ACTIVE, start_scale);
+      layer->element_id(), ElementListType::ACTIVE, start_scale);
 }
 
 bool LayerTreeHost::HasAnyAnimationTargetingProperty(
     const Layer* layer,
     TargetProperty::Type property) const {
-  return animation_host_->HasAnyAnimationTargetingProperty(layer->id(),
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->HasAnyAnimationTargetingProperty(layer->element_id(),
                                                            property);
 }
 
 bool LayerTreeHost::AnimationsPreserveAxisAlignment(const Layer* layer) const {
-  return animation_host_->AnimationsPreserveAxisAlignment(layer->id());
+  if (!layer->element_id())
+    return true;
+
+  return animation_host_->AnimationsPreserveAxisAlignment(layer->element_id());
 }
 
 bool LayerTreeHost::HasAnyAnimation(const Layer* layer) const {
-  return animation_host_->HasAnyAnimation(layer->id());
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->HasAnyAnimation(layer->element_id());
 }
 
 bool LayerTreeHost::HasActiveAnimationForTesting(const Layer* layer) const {
-  return animation_host_->HasActiveAnimationForTesting(layer->id());
+  if (!layer->element_id())
+    return false;
+
+  return animation_host_->HasActiveAnimationForTesting(layer->element_id());
 }
 
 bool LayerTreeHost::IsSingleThreaded() const {
   DCHECK(compositor_mode_ != CompositorMode::SINGLE_THREADED ||
          !task_runner_provider_->HasImplThread());
   return compositor_mode_ == CompositorMode::SINGLE_THREADED;
 }
 
 bool LayerTreeHost::IsThreaded() const {
   DCHECK(compositor_mode_ != CompositorMode::THREADED ||
@@ skipping 184 matching lines @@
   int seq_num = property_trees_.sequence_number;
   LayerTreeHostCommon::CallFunctionForEveryLayer(this, [seq_num](Layer* layer) {
     layer->set_property_tree_sequence_number(seq_num);
   });
 
   surface_id_namespace_ = proto.surface_id_namespace();
   next_surface_sequence_ = proto.next_surface_sequence();
 }
 
 }  // namespace cc