Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationEffect.cpp

Issue 1944603003: Make AnimationEffectReadOnly.getComputedTiming() consistent with Web Animations spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update expectations Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationEffect.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationEffect.cpp b/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
index 23543000b163cab0c424437174f0ee4f9ac653d8..168cbc55f5c13d3836bf375957cca5205ca99ff6 100644
--- a/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
@@ -94,10 +94,9 @@ void AnimationEffect::updateSpecifiedTiming(const Timing& timing)
specifiedTimingChanged();
}
-void AnimationEffect::computedTiming(ComputedTimingProperties& computedTiming)
+void AnimationEffect::getComputedTiming(ComputedTimingProperties& computedTiming)
{
// ComputedTimingProperties members.
- computedTiming.setStartTime(0);
computedTiming.setEndTime(endTimeInternal() * 1000);
computedTiming.setActiveDuration(activeDurationInternal() * 1000);
@@ -105,7 +104,7 @@ void AnimationEffect::computedTiming(ComputedTimingProperties& computedTiming)
// will treat these as undefined.
if (ensureCalculated().isInEffect) {
computedTiming.setLocalTime(ensureCalculated().localTime * 1000);
- computedTiming.setTimeFraction(ensureCalculated().timeFraction);
+ computedTiming.setProgress(ensureCalculated().progress);
computedTiming.setCurrentIteration(ensureCalculated().currentIteration);
}
@@ -125,10 +124,10 @@ void AnimationEffect::computedTiming(ComputedTimingProperties& computedTiming)
computedTiming.setEasing(specifiedTiming().timingFunction->toString());
}
-ComputedTimingProperties AnimationEffect::computedTiming()
+ComputedTimingProperties AnimationEffect::getComputedTiming()
{
ComputedTimingProperties result;
- computedTiming(result);
+ getComputedTiming(result);
return result;
}
@@ -150,7 +149,7 @@ void AnimationEffect::updateInheritedTime(double inheritedTime, TimingUpdateReas
const double activeTime = calculateActiveTime(activeDuration, resolvedFillMode(m_timing.fillMode, isKeyframeEffect()), localTime, parentPhase, currentPhase, m_timing);
double currentIteration;
- double timeFraction;
+ double progress;
if (const double iterationDuration = this->iterationDuration()) {
const double startOffset = multiplyZeroAlwaysGivesZero(m_timing.iterationStart, iterationDuration);
ASSERT(startOffset >= 0);
@@ -165,9 +164,9 @@ void AnimationEffect::updateInheritedTime(double inheritedTime, TimingUpdateReas
// There is an open issue against the spec to fix this:
// https://github.com/w3c/web-animations/issues/142
if (!std::isfinite(iterationDuration))
- timeFraction = fmod(m_timing.iterationStart, 1.0);
+ progress = fmod(m_timing.iterationStart, 1.0);
else
- timeFraction = transformedTime / iterationDuration;
+ progress = transformedTime / iterationDuration;
if (!isNull(iterationTime)) {
timeToNextIteration = (iterationDuration - iterationTime) / std::abs(m_timing.playbackRate);
@@ -189,11 +188,11 @@ void AnimationEffect::updateInheritedTime(double inheritedTime, TimingUpdateReas
const double iterationTime = calculateIterationTime(localIterationDuration, localRepeatedDuration, scaledActiveTime, startOffset, m_timing);
currentIteration = calculateCurrentIteration(localIterationDuration, iterationTime, scaledActiveTime, m_timing);
- timeFraction = calculateTransformedTime(currentIteration, localIterationDuration, iterationTime, m_timing);
+ progress = calculateTransformedTime(currentIteration, localIterationDuration, iterationTime, m_timing);
}
m_calculated.currentIteration = currentIteration;
- m_calculated.timeFraction = timeFraction;
+ m_calculated.progress = progress;
m_calculated.phase = currentPhase;
m_calculated.isInEffect = !isNull(activeTime);

Powered by Google App Engine
This is Rietveld 408576698