Adding logic to detect and log invalid RDP settings

Adding logic to detect and log invalid RDP settings

This change adds code that checks the values of a set of registry keys which
have specific required values, otherwise we know we cannot establish an RDP
session.  The code will log an error if the incorrect value is found and will
prevent the RDP session from being created.  If for some reason we fail to read
the registry key, a warning will be logged but we won't prevent the attempt to
create an RDP session.

BUG=506555
Committed: https://crrev.com/0bf730db647d382b272ce899d7eeb01c96a6655d
Cr-Commit-Position: refs/heads/master@{#391338}

[joedow, 2016-05-02 23:20:40]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-05-02 23:20:41]

This CL makes it easier to detect common RDP connection failure reasons.  If we
find a value which would prevent us from establishing a connection, I log it and
prevent the connection from being established proactively.

We had discussed also logging this value to the event log.  After looking at the
code, we only log connection stats to the event log so I'd like to give our
logging strategy a bit more thought before adding that in here.

PTAL!

Thanks,
Joe

[Jamie, 2016-05-03 00:06:52]

lgtm

[joedow, 2016-05-03 02:29:45]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-05-03 02:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 02:30:03]

This CL has an open dependency (Issue 1935003003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[joedow, 2016-05-03 20:02:49]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-05-03 20:03:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1944513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1944513002/1

[commit-bot: I haz the power, 2016-05-03 20:09:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-03 20:11:00]

Description was changed from

==========
Adding logic to detect and log invalid RDP settings

This change adds code that checks the values of a set of registry keys which
have specific required values, otherwise we know we cannot establish an RDP
session.  The code will log an error if the incorrect value is found and will
prevent the RDP session from being created.  If for some reason we fail to read
the registry key, a warning will be logged but we won't prevent the attempt to
create an RDP session.

BUG=506555
==========

to

==========
Adding logic to detect and log invalid RDP settings

This change adds code that checks the values of a set of registry keys which
have specific required values, otherwise we know we cannot establish an RDP
session.  The code will log an error if the incorrect value is found and will
prevent the RDP session from being created.  If for some reason we fail to read
the registry key, a warning will be logged but we won't prevent the attempt to
create an RDP session.

BUG=506555

Committed: https://crrev.com/0bf730db647d382b272ce899d7eeb01c96a6655d
Cr-Commit-Position: refs/heads/master@{#391338}
==========

[commit-bot: I haz the power, 2016-05-03 20:11:01]

Patchset 1 (id:??) landed as
https://crrev.com/0bf730db647d382b272ce899d7eeb01c96a6655d
Cr-Commit-Position: refs/heads/master@{#391338}