Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1944503002: Adds more DBC assembler tests. (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -20 lines) Patch
M runtime/vm/assembler_arm64_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/assembler_dbc_test.cc View 2 chunks +109 lines, -0 lines 0 comments Download
M runtime/vm/stack_frame.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/unit_test.h View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/vm/unit_test.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 7 months ago (2016-05-02 23:03:53 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 7 months ago (2016-05-03 07:14:08 UTC) #3
zra
4 years, 7 months ago (2016-05-03 16:01:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1d241922fb0a34ca1832e96d8e669068bfd406c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698