Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: chrome/browser/resources/md_user_manager/import_supervised_user.html

Issue 1944463002: MD User Manager: fixes accessibility issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md-user-manager-user-pods-css
Patch Set: Addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_user_manager/import_supervised_user.html
diff --git a/chrome/browser/resources/md_user_manager/import_supervised_user.html b/chrome/browser/resources/md_user_manager/import_supervised_user.html
index 631aa33272bd6525f2d875536d45095030b73763..c2b152d13b5a12feb3c64f9fb42a27ea5c9ab41e 100644
--- a/chrome/browser/resources/md_user_manager/import_supervised_user.html
+++ b/chrome/browser/resources/md_user_manager/import_supervised_user.html
@@ -4,8 +4,10 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<dom-module id="import-supervised-user">
<template>
@@ -39,9 +41,11 @@
padding: 16px;
}
- #title-bar iron-icon {
- --iron-icon-height: 12px;
- --iron-icon-width: 12px;
+ #title-bar paper-icon-button {
+ --paper-icon-button: {
+ height: 36px;
+ width: 36px;
+ };
}
#message {
@@ -50,33 +54,51 @@
word-wrap: break-word;
}
- #user-list .list-item {
- align-items: center;
- display: flex;
- height: 52px;
- padding: 0 16px;
+ paper-listbox {
+ --paper-listbox: {
+ padding: 0;
+ color: inherit;
+ };
+ }
+
+ paper-listbox paper-item {
+ --paper-item: {
+ font-size: inherit;
+ height: 52px;
+ line-height: inherit;
+ padding: 0 16px;
+ };
+ --paper-item-disabled: {
+ color: inherit;
+ };
+ --paper-item-focused: {
+ background: rgba(0, 0, 0, .04);
+ };
+ --paper-item-focused-before: {
+ background: none;
+ };
+ --paper-item-selected: {
+ background: rgba(0, 0, 0, .04);
+ font-weight: normal;
+ };
}
- #user-list .list-item .profile-img {
+ paper-listbox paper-item .profile-img {
flex-shrink: 0;
}
- #user-list .list-item .profile-name {
+ paper-listbox paper-item .profile-name {
-webkit-margin-start: 10px;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
- #user-list .list-item .on-device {
+ paper-listbox paper-item .on-device {
-webkit-margin-start: 10px;
flex-shrink: 0;
}
- #user-list .list-item.selectable.iron-selected {
- background: var(--paper-grey-200);
- }
-
#actions {
margin-top: 20px;
padding: 16px;
@@ -87,23 +109,21 @@
<div id="dialog">
<div id="title-bar" class="horizontal justified layout">
<span id="title">$i18n{supervisedUserImportTitle}</span>
- <iron-icon icon="close" on-tap="onCancelTap_"></iron-icon>
+ <paper-icon-button icon="close" on-tap="onCancelTap_">
+ </paper-icon-button>
</div>
<div id="message">[[getMessage_(supervisedUsers_)]]</div>
- <div id="user-list" class="content-area">
- <iron-selector selected="{{supervisedUserIndex_}}"
- selectable=".selectable">
- <template is="dom-repeat" items="[[supervisedUsers_]]">
- <div class$="[[getUserClassNames_(item)]]">
- <img class="profile-img" src="[[item.iconURL]]"></img>
- <div class="profile-name">[[item.name]]</div>
- <div class="on-device" hidden="[[!item.onCurrentDevice]]">
- $i18n{supervisedUserAlreadyOnThisDevice}
- </div>
+ <paper-listbox selected="{{supervisedUserIndex_}}">
+ <template is="dom-repeat" items="[[supervisedUsers_]]">
+ <paper-item disabled="[[item.onCurrentDevice]]">
+ <img class="profile-img" src="[[item.iconURL]]"></img>
+ <div class="profile-name">[[item.name]]</div>
+ <div class="on-device" hidden="[[!item.onCurrentDevice]]">
+ $i18n{supervisedUserAlreadyOnThisDevice}
</div>
- </template>
- </iron-selector>
- </div>
+ </paper-item>
+ </template>
+ </paper-listbox>
<div id="actions" class="horizontal end-justified layout">
<paper-button id="cancel" class="action secondary"
on-tap="onCancelTap_">

Powered by Google App Engine
This is Rietveld 408576698