components/safe_browsing_db/v4_get_hash_protocol_manager.h - Issue 1944433002: Make V4GetHashProtocolManager::RegisterFactory safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.h

Issue 1944433002: Make V4GetHashProtocolManager::RegisterFactory safe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-enable the right tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/database_manager_unittest.cc ('K') | « components/safe_browsing_db/database_manager_unittest.cc ('k') | components/safe_browsing_db/v4_get_hash_protocol_manager.cc » ('j') | components/safe_browsing_db/v4_get_hash_protocol_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_get_hash_protocol_manager.h

diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.h b/components/safe_browsing_db/v4_get_hash_protocol_manager.h

index 72f01e01a4656fcceab1e4508ca60e17edee8bed..85fb177ae1b484364ad7b575180dd3618fb05742 100644

--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.h

+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.h

@@ -52,9 +52,8 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,

// Makes the passed |factory| the factory used to instantiate

// a V4GetHashProtocolManager. Useful for tests.

- static void RegisterFactory(V4GetHashProtocolManagerFactory* factory) {

- factory_ = factory;

- }

+ static void RegisterFactory(

+ std::unique_ptr<V4GetHashProtocolManagerFactory> factory);

// Create an instance of the safe browsing v4 protocol manager.

static V4GetHashProtocolManager* Create(